feat: fully featured token checks
All checks were successful
Build and Deploy Go App / build (push) Successful in 6m39s
Build and Deploy Go App / deploy (push) Successful in 46s

This commit is contained in:
nihonium 2025-12-06 06:25:21 +03:00
parent 7956a8a961
commit 713c0adc14
Signed by: nihonium
GPG key ID: 0251623741027CFC
6 changed files with 226 additions and 77 deletions

View file

@ -56,6 +56,9 @@ type ServerInterface interface {
// Get service impersontaion token // Get service impersontaion token
// (POST /get-impersonation-token) // (POST /get-impersonation-token)
GetImpersonationToken(c *gin.Context) GetImpersonationToken(c *gin.Context)
// Refreshes access_token and refresh_token
// (GET /refresh-tokens)
RefreshTokens(c *gin.Context)
// Sign in a user and return JWT // Sign in a user and return JWT
// (POST /sign-in) // (POST /sign-in)
PostSignIn(c *gin.Context) PostSignIn(c *gin.Context)
@ -88,6 +91,19 @@ func (siw *ServerInterfaceWrapper) GetImpersonationToken(c *gin.Context) {
siw.Handler.GetImpersonationToken(c) siw.Handler.GetImpersonationToken(c)
} }
// RefreshTokens operation middleware
func (siw *ServerInterfaceWrapper) RefreshTokens(c *gin.Context) {
for _, middleware := range siw.HandlerMiddlewares {
middleware(c)
if c.IsAborted() {
return
}
}
siw.Handler.RefreshTokens(c)
}
// PostSignIn operation middleware // PostSignIn operation middleware
func (siw *ServerInterfaceWrapper) PostSignIn(c *gin.Context) { func (siw *ServerInterfaceWrapper) PostSignIn(c *gin.Context) {
@ -142,10 +158,17 @@ func RegisterHandlersWithOptions(router gin.IRouter, si ServerInterface, options
} }
router.POST(options.BaseURL+"/get-impersonation-token", wrapper.GetImpersonationToken) router.POST(options.BaseURL+"/get-impersonation-token", wrapper.GetImpersonationToken)
router.GET(options.BaseURL+"/refresh-tokens", wrapper.RefreshTokens)
router.POST(options.BaseURL+"/sign-in", wrapper.PostSignIn) router.POST(options.BaseURL+"/sign-in", wrapper.PostSignIn)
router.POST(options.BaseURL+"/sign-up", wrapper.PostSignUp) router.POST(options.BaseURL+"/sign-up", wrapper.PostSignUp)
} }
type ClientErrorResponse struct {
}
type ServerErrorResponse struct {
}
type UnauthorizedErrorResponse struct { type UnauthorizedErrorResponse struct {
} }
@ -176,6 +199,42 @@ func (response GetImpersonationToken401Response) VisitGetImpersonationTokenRespo
return nil return nil
} }
type RefreshTokensRequestObject struct {
}
type RefreshTokensResponseObject interface {
VisitRefreshTokensResponse(w http.ResponseWriter) error
}
type RefreshTokens200Response struct {
}
func (response RefreshTokens200Response) VisitRefreshTokensResponse(w http.ResponseWriter) error {
w.WriteHeader(200)
return nil
}
type RefreshTokens400Response = ClientErrorResponse
func (response RefreshTokens400Response) VisitRefreshTokensResponse(w http.ResponseWriter) error {
w.WriteHeader(400)
return nil
}
type RefreshTokens401Response = UnauthorizedErrorResponse
func (response RefreshTokens401Response) VisitRefreshTokensResponse(w http.ResponseWriter) error {
w.WriteHeader(401)
return nil
}
type RefreshTokens500Response = ServerErrorResponse
func (response RefreshTokens500Response) VisitRefreshTokensResponse(w http.ResponseWriter) error {
w.WriteHeader(500)
return nil
}
type PostSignInRequestObject struct { type PostSignInRequestObject struct {
Body *PostSignInJSONRequestBody Body *PostSignInJSONRequestBody
} }
@ -227,6 +286,9 @@ type StrictServerInterface interface {
// Get service impersontaion token // Get service impersontaion token
// (POST /get-impersonation-token) // (POST /get-impersonation-token)
GetImpersonationToken(ctx context.Context, request GetImpersonationTokenRequestObject) (GetImpersonationTokenResponseObject, error) GetImpersonationToken(ctx context.Context, request GetImpersonationTokenRequestObject) (GetImpersonationTokenResponseObject, error)
// Refreshes access_token and refresh_token
// (GET /refresh-tokens)
RefreshTokens(ctx context.Context, request RefreshTokensRequestObject) (RefreshTokensResponseObject, error)
// Sign in a user and return JWT // Sign in a user and return JWT
// (POST /sign-in) // (POST /sign-in)
PostSignIn(ctx context.Context, request PostSignInRequestObject) (PostSignInResponseObject, error) PostSignIn(ctx context.Context, request PostSignInRequestObject) (PostSignInResponseObject, error)
@ -280,6 +342,31 @@ func (sh *strictHandler) GetImpersonationToken(ctx *gin.Context) {
} }
} }
// RefreshTokens operation middleware
func (sh *strictHandler) RefreshTokens(ctx *gin.Context) {
var request RefreshTokensRequestObject
handler := func(ctx *gin.Context, request interface{}) (interface{}, error) {
return sh.ssi.RefreshTokens(ctx, request.(RefreshTokensRequestObject))
}
for _, middleware := range sh.middlewares {
handler = middleware(handler, "RefreshTokens")
}
response, err := handler(ctx, request)
if err != nil {
ctx.Error(err)
ctx.Status(http.StatusInternalServerError)
} else if validResponse, ok := response.(RefreshTokensResponseObject); ok {
if err := validResponse.VisitRefreshTokensResponse(ctx.Writer); err != nil {
ctx.Error(err)
}
} else if response != nil {
ctx.Error(fmt.Errorf("unexpected response type: %T", response))
}
}
// PostSignIn operation middleware // PostSignIn operation middleware
func (sh *strictHandler) PostSignIn(ctx *gin.Context) { func (sh *strictHandler) PostSignIn(ctx *gin.Context) {
var request PostSignInRequestObject var request PostSignInRequestObject

10
auth/claims.go Normal file
View file

@ -0,0 +1,10 @@
package auth
import "github.com/golang-jwt/jwt/v5"
type TokenClaims struct {
UserID string `json:"user_id"`
Type string `json:"type"`
ImpID *string `json:"imp_id,omitempty"`
jwt.RegisteredClaims
}

View file

@ -116,6 +116,22 @@ paths:
"401": "401":
$ref: '#/components/responses/UnauthorizedError' $ref: '#/components/responses/UnauthorizedError'
/refresh-tokens:
get:
summary: Refreshes access_token and refresh_token
operationId: refreshTokens
tags: [Auth]
responses:
# This one sets two cookies: access_token and refresh_token
"200":
description: Refresh success
"400":
$ref: '#/components/responses/ClientError'
"401":
$ref: '#/components/responses/UnauthorizedError'
"500":
$ref: '#/components/responses/ServerError'
components: components:
securitySchemes: securitySchemes:
bearerAuth: bearerAuth:
@ -124,3 +140,7 @@ components:
responses: responses:
UnauthorizedError: UnauthorizedError:
description: Access token is missing or invalid description: Access token is missing or invalid
ServerError:
description: ServerError
ClientError:
description: ClientError

View file

@ -47,28 +47,35 @@ func CheckPassword(password, hash string) (bool, error) {
return argon2id.ComparePasswordAndHash(password, hash) return argon2id.ComparePasswordAndHash(password, hash)
} }
func (s Server) generateImpersonationToken(userID string, impersonated_by string) (accessToken string, err error) { func (s *Server) generateImpersonationToken(userID string, impersonatedBy string) (string, error) {
accessClaims := jwt.MapClaims{ now := time.Now()
"user_id": userID, claims := auth.TokenClaims{
"exp": time.Now().Add(15 * time.Minute).Unix(), UserID: userID,
"imp_id": impersonated_by, ImpID: &impersonatedBy,
Type: "access",
RegisteredClaims: jwt.RegisteredClaims{
IssuedAt: jwt.NewNumericDate(now),
ExpiresAt: jwt.NewNumericDate(now.Add(15 * time.Minute)),
ID: generateJTI(),
},
} }
at := jwt.NewWithClaims(jwt.SigningMethodHS256, accessClaims) token := jwt.NewWithClaims(jwt.SigningMethodHS256, claims)
return token.SignedString([]byte(s.JwtPrivateKey))
accessToken, err = at.SignedString([]byte(s.JwtPrivateKey))
if err != nil {
return "", err
} }
return accessToken, nil func (s *Server) generateTokens(userID string) (accessToken string, refreshToken string, csrfToken string, err error) {
} now := time.Now()
func (s Server) generateTokens(userID string) (accessToken string, refreshToken string, csrfToken string, err error) { // Access token (15 мин)
accessClaims := jwt.MapClaims{ accessClaims := auth.TokenClaims{
"user_id": userID, UserID: userID,
"exp": time.Now().Add(15 * time.Minute).Unix(), Type: "access",
//TODO: add created_at RegisteredClaims: jwt.RegisteredClaims{
IssuedAt: jwt.NewNumericDate(now),
ExpiresAt: jwt.NewNumericDate(now.Add(15 * time.Minute)),
ID: generateJTI(),
},
} }
at := jwt.NewWithClaims(jwt.SigningMethodHS256, accessClaims) at := jwt.NewWithClaims(jwt.SigningMethodHS256, accessClaims)
accessToken, err = at.SignedString([]byte(s.JwtPrivateKey)) accessToken, err = at.SignedString([]byte(s.JwtPrivateKey))
@ -76,9 +83,15 @@ func (s Server) generateTokens(userID string) (accessToken string, refreshToken
return "", "", "", err return "", "", "", err
} }
refreshClaims := jwt.MapClaims{ // Refresh token (7 дней)
"user_id": userID, refreshClaims := auth.TokenClaims{
"exp": time.Now().Add(7 * 24 * time.Hour).Unix(), UserID: userID,
Type: "refresh",
RegisteredClaims: jwt.RegisteredClaims{
IssuedAt: jwt.NewNumericDate(now),
ExpiresAt: jwt.NewNumericDate(now.Add(7 * 24 * time.Hour)),
ID: generateJTI(),
},
} }
rt := jwt.NewWithClaims(jwt.SigningMethodHS256, refreshClaims) rt := jwt.NewWithClaims(jwt.SigningMethodHS256, refreshClaims)
refreshToken, err = rt.SignedString([]byte(s.JwtPrivateKey)) refreshToken, err = rt.SignedString([]byte(s.JwtPrivateKey))
@ -86,6 +99,7 @@ func (s Server) generateTokens(userID string) (accessToken string, refreshToken
return "", "", "", err return "", "", "", err
} }
// CSRF token
csrfBytes := make([]byte, 32) csrfBytes := make([]byte, 32)
_, err = rand.Read(csrfBytes) _, err = rand.Read(csrfBytes)
if err != nil { if err != nil {
@ -219,56 +233,56 @@ func (s Server) GetImpersonationToken(ctx context.Context, req auth.GetImpersona
return auth.GetImpersonationToken200JSONResponse{AccessToken: accessToken}, nil return auth.GetImpersonationToken200JSONResponse{AccessToken: accessToken}, nil
} }
// func (s Server) PostAuthRefreshToken(ctx context.Context, req auth.PostAuthRefreshTokenRequestObject) (auth.PostAuthRefreshTokenResponseObject, error) { func (s Server) RefreshTokens(ctx context.Context, req auth.RefreshTokensRequestObject) (auth.RefreshTokensResponseObject, error) {
// valid := false ginCtx, ok := ctx.Value(gin.ContextKey).(*gin.Context)
// var userID *string if !ok {
// var errStr *string log.Print("failed to get gin context")
return auth.RefreshTokens500Response{}, fmt.Errorf("failed to get gin.Context from context.Context")
}
// token, err := jwt.Parse(req.Body.Token, func(t *jwt.Token) (interface{}, error) { rtCookie, err := ginCtx.Request.Cookie("refresh_token")
// if _, ok := t.Method.(*jwt.SigningMethodHMAC); !ok { if err != nil {
// return nil, fmt.Errorf("unexpected signing method") log.Print("failed to get refresh_token cookie")
// } return auth.RefreshTokens400Response{}, fmt.Errorf("failed to get refresh_token cookie")
// return refreshSecret, nil }
// })
// if err != nil { refreshToken := rtCookie.Value
// e := err.Error()
// errStr = &e
// return auth.PostAuthVerifyToken200JSONResponse{
// Valid: &valid,
// UserId: userID,
// Error: errStr,
// }, nil
// }
// if claims, ok := token.Claims.(jwt.MapClaims); ok && token.Valid { token, err := jwt.ParseWithClaims(refreshToken, &auth.TokenClaims{}, func(t *jwt.Token) (interface{}, error) {
// if uid, ok := claims["user_id"].(string); ok { if _, ok := t.Method.(*jwt.SigningMethodHMAC); !ok {
// // Refresh token is valid, generate new tokens return nil, fmt.Errorf("unexpected signing method")
// newAccessToken, newRefreshToken, _ := generateTokens(uid) }
// valid = true return []byte(s.JwtPrivateKey), nil
// userID = &uid })
// return auth.PostAuthVerifyToken200JSONResponse{ if err != nil || !token.Valid {
// Valid: &valid, log.Print("invalid refresh token")
// UserId: userID, return auth.RefreshTokens401Response{}, nil
// Error: nil, }
// Token: &newAccessToken, // return new access token
// // optionally return newRefreshToken as well
// }, nil
// } else {
// e := "user_id not found in refresh token"
// errStr = &e
// }
// } else {
// e := "invalid refresh token claims"
// errStr = &e
// }
// return auth.PostAuthVerifyToken200JSONResponse{ claims, ok := token.Claims.(*auth.TokenClaims)
// Valid: &valid, if !ok || claims.UserID == "" {
// UserId: userID, log.Print("invalid refresh token claims")
// Error: errStr, return auth.RefreshTokens401Response{}, nil
// }, nil }
// } if claims.Type != "refresh" {
log.Errorf("token is not a refresh token")
return auth.RefreshTokens401Response{}, nil
}
accessToken, refreshToken, csrfToken, err := s.generateTokens(claims.UserID)
if err != nil {
log.Errorf("failed to generate tokens for user %s: %v", claims.UserID, err)
return auth.RefreshTokens500Response{}, nil
}
// TODO: check cookie settings carefully
ginCtx.SetSameSite(http.SameSiteStrictMode)
ginCtx.SetCookie("access_token", accessToken, 900, "/api", "", false, true)
ginCtx.SetCookie("refresh_token", refreshToken, 1209600, "/auth", "", false, true)
ginCtx.SetCookie("xsrf_token", csrfToken, 1209600, "/", "", false, false)
return auth.RefreshTokens200Response{}, nil
}
func ExtractBearerToken(header string) (string, error) { func ExtractBearerToken(header string) (string, error) {
const prefix = "Bearer " const prefix = "Bearer "
@ -277,3 +291,9 @@ func ExtractBearerToken(header string) (string, error) {
} }
return header[len(prefix):], nil return header[len(prefix):], nil
} }
func generateJTI() string {
b := make([]byte, 16)
_, _ = rand.Read(b)
return base64.RawURLEncoding.EncodeToString(b)
}

View file

@ -46,7 +46,7 @@ func main() {
log.Info("allow origins:", AppConfig.ServiceAddress) log.Info("allow origins:", AppConfig.ServiceAddress)
r.Use(cors.New(cors.Config{ r.Use(cors.New(cors.Config{
AllowOrigins: []string{"*"}, AllowOrigins: []string{AppConfig.ServiceAddress},
AllowMethods: []string{"GET", "POST", "PUT", "DELETE"}, AllowMethods: []string{"GET", "POST", "PUT", "DELETE"},
AllowHeaders: []string{"Origin", "Content-Type", "Accept"}, AllowHeaders: []string{"Origin", "Content-Type", "Accept"},
ExposeHeaders: []string{"Content-Length"}, ExposeHeaders: []string{"Content-Length"},

View file

@ -3,8 +3,11 @@ package middleware
import ( import (
"context" "context"
"errors" "errors"
"fmt"
"net/http" "net/http"
"nyanimedb/auth"
"github.com/gin-gonic/gin" "github.com/gin-gonic/gin"
"github.com/golang-jwt/jwt/v5" "github.com/golang-jwt/jwt/v5"
) )
@ -37,12 +40,18 @@ func JWTAuthMiddleware(secret string) gin.HandlerFunc {
} }
// 2. Парсим токен с MapClaims // 2. Парсим токен с MapClaims
token, err := jwt.Parse(tokenStr, func(t *jwt.Token) (interface{}, error) { token, err := jwt.ParseWithClaims(tokenStr, &auth.TokenClaims{}, func(t *jwt.Token) (interface{}, error) {
if t.Method != jwt.SigningMethodHS256 { if _, ok := t.Method.(*jwt.SigningMethodHMAC); !ok {
return nil, errors.New("unexpected signing method: " + t.Method.Alg()) return nil, fmt.Errorf("unexpected signing method")
} }
return []byte(secret), nil // ← конвертируем string → []byte return []byte(secret), nil
}) })
// token, err := jwt.Parse(tokenStr, func(t *jwt.Token) (interface{}, error) {
// if t.Method != jwt.SigningMethodHS256 {
// return nil, errors.New("unexpected signing method: " + t.Method.Alg())
// }
// return []byte(secret), nil // ← конвертируем string → []byte
// })
if err != nil { if err != nil {
abortWithJSON(c, http.StatusUnauthorized, "invalid token: "+err.Error()) abortWithJSON(c, http.StatusUnauthorized, "invalid token: "+err.Error())
return return
@ -55,20 +64,23 @@ func JWTAuthMiddleware(secret string) gin.HandlerFunc {
} }
// 4. Извлекаем user_id из claims // 4. Извлекаем user_id из claims
claims, ok := token.Claims.(jwt.MapClaims) claims, ok := token.Claims.(*auth.TokenClaims)
if !ok { if !ok {
abortWithJSON(c, http.StatusUnauthorized, "invalid claims format") abortWithJSON(c, http.StatusUnauthorized, "invalid claims format")
return return
} }
userID, ok := claims["user_id"].(string) if claims.UserID == "" {
if !ok || userID == "" {
abortWithJSON(c, http.StatusUnauthorized, "user_id claim missing or invalid") abortWithJSON(c, http.StatusUnauthorized, "user_id claim missing or invalid")
return return
} }
if claims.Type != "access" {
abortWithJSON(c, http.StatusUnauthorized, "token type is not access")
return
}
// 5. Сохраняем в контексте // 5. Сохраняем в контексте
c.Set("user_id", userID) c.Set("user_id", claims.UserID)
// 6. Для oapi-codegen — кладём gin.Context в request context // 6. Для oapi-codegen — кладём gin.Context в request context
GinContextToContext(c) GinContextToContext(c)